Skip to content
This repository has been archived by the owner on Mar 29, 2021. It is now read-only.

Commit

Permalink
Fix for Issue #30 and also fixed running when project loading (#36)
Browse files Browse the repository at this point in the history
* Issue #30 - Errors in the "Error List window" do not go to the correct line number

* Target was executing when project was unloaded/loaded instead of just during build time
  • Loading branch information
esampsonite authored and Josh Goldberg committed Jun 6, 2016
1 parent 2d0e894 commit f85660b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/TSLint.MSBuild.targets
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<Target
AfterTargets="CompileTypeScript"
Condition="'@(TypeScriptCompile)' != ''"
Condition="'@(TypeScriptCompile)' != '' and '$(BuildingProject)' == 'true'"
Name="TSLint">
<PropertyGroup>
<TSLintBreakBuildOnError Condition="'$(TSLintBreakBuildOnError)' == ''">false</TSLintBreakBuildOnError>
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function formatOutput(lintError: string | any): string {
return lintError;
}

return lintError.name.replace("/", "\\")
return lintError.name.replace(/\//g, "\\")
+ `(${(lintError.startPosition.line + 1)},${(lintError.startPosition.character + 1)})`
+ `: error tslint-${lintError.ruleName}`
+ `: TSLint failure: ${lintError.failure}.`;
Expand Down

0 comments on commit f85660b

Please sign in to comment.