This repository was archived by the owner on Feb 3, 2022. It is now read-only.
Merged
Conversation
JoshOrndorff
commented
Aug 21, 2020
text minor reworks
…orkshop into joshy-rc6
JoshOrndorff
commented
Aug 21, 2020
| FullClient, FullBackend, FullSelectChain, | ||
| BasicQueue<Block, TransactionFor<FullClient, Block>>, | ||
| sc_transaction_pool::FullPool<Block, FullClient>, | ||
| sc_consensus_pow::PowBlockImport<Block, Arc<FullClient>, FullClient, FullSelectChain, Sha3Algorithm<FullClient>, impl sp_consensus::CanAuthorWith<Block>>, |
Owner
Author
There was a problem hiding this comment.
@dvdplm This is the type I ended up using thanks to @andresila 's help. I believe you were having a similar issue.
riusricardo
reviewed
Aug 21, 2020
riusricardo
left a comment
riusricardo
left a comment
There was a problem hiding this comment.
The README needs some fixed/updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the repo to use Substrate 2.0.0-rc6
There is a slight ugliness related to paritytech/substrate#6862 when calculating the type of
can_author_within the light client. A warning is thrown when compiling, and I've chosen not to suppress the warning as a reminder to fix this in the future.