Clean up Docker Compose with Anchors #1272
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use anchors in order to not repeat ~30 variables 3 times per file.
This pull request includes significant changes to the
docker-composeconfiguration files to improve environment variable management and streamline service definitions. The most important changes involve the introduction of shared environment variable groups and the reorganization of service-specific environment variables.Improvements to environment variable management:
x-common-envandx-oauth-envto define shared environment variables, reducing redundancy across services (docker-compose-dev.yml,docker-compose-nostreamlit-dev.yml,docker-compose-nostreamlit.yml). [1] [2] [3]Reorganization of service-specific environment variables:
agixtservice to use the new environment variable groups and added missing Stripe-related environment variables (docker-compose-dev.yml,docker-compose-nostreamlit-dev.yml,docker-compose-nostreamlit.yml). [1] [2] [3]streamlitandagixtinteractiveservices to use the new environment variable groups and removed redundant environment variables (docker-compose-dev.yml,docker-compose-nostreamlit-dev.yml,docker-compose-nostreamlit.yml). [1] [2] [3]These changes aim to simplify the configuration files, making them easier to maintain and reducing the risk of errors due to duplicated environment variables.