fix(core): Error propagation mismatch #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 122 125 +3
===========================================
Files 7 7
Lines 298 302 +4
Branches 10 10
===========================================
+ Hits 298 302 +4 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callbacks (Functions and Consumers) of the API that receive the actual error as a parameter need to change their generic type from
? super Eto aThrowable. Because the error propagates downstream in the API, we cannot guarantee that the current error type matches the Function/Consumer parameter type. If the types mismatch, we'll get aClassCastExceptioninstead.