-
Notifications
You must be signed in to change notification settings - Fork 40
Parser refactor, package upgrades, and bug fixes. #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jorriss
wants to merge
21
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truing up dev with master
Upgraded all modules to the current version, replaced them with newer modules, or removed them all together. Includes: jQuery, Bootstrap, DataTables, Moment -> Luxon, Numeral (removed), Purl (removed), jQuery Cookies (removed).
Close #62
Also reduced reliance on jQuery. Though we still need to to use DataTables.
Refactored the parser to separate the UI from the parsing data. This should assist in creating new features more easily. Also separated logic into different modules. Introduced vite to assist in building the project.
Moved "Tables have scrollbars" into language files. Had vite search and replace version number in html.
To be a bit more clear.
The Google Analytics script is in the json file .env.json. If the file doesn't exist the analytics script won't be added.
When loading a StatsIOInfo object if the value array is less than the columns array the load would continue and load undefined for the remaining columns. A check was added in the loop to check if the range was out of bounds, if it was the new StatsIOInfo object would be returned. There are situations where the columns will mismatch from the values (i.e. Columnstore). We many need to parse each column in each line.
This was referenced Jun 4, 2025
Closed
Also fixed the formatting number of table data. The international formatting was causing some of the columns to be treated as a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ff47fed - Big changes to parsing and displaying parsing results
b28728a - Moved display code into a module.
9b0ca02 - Refactored the parsing engine to parse new-ish IO columns.
0fad233 - Renamed IO table css classes.
2ecff48 - Added unit tests.
Bug fixes:
#29 Clear the "Show Example Statistics IO Output" check-box when the text entry field is modified.
#30 If the "Show Example Statistics IO Output" check-box is unchecked the input text field is cleared.
#50 Bug in scan count and logical reads
#55 Invalid numbers for Scan count / Total logical
#56 Aggregating incorrectly
#60 Read-ahead-reads not reported
#61 Copy Results Button
#62 Add a Scroll To Top button at that bottom of the page.
#63 Add new-ish Statistics IO columns