Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added <scope>dependency</scope> to dependency #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhruviyengar
Copy link

The discord server is filled with people with noclassdeffound, simply saved by adding the dependency scope to the dependency.

The discord server is filled with people with noclassdeffound, simply saved by adding the dependency scope to the dependency.
@Erik-For
Copy link

I think this is a good change

@JordanOsterberg
Copy link
Owner

Can you verify that this change does resolve the exception if instructions are followed? Will merge pending that verification.

@sqlongithub
Copy link

sqlongithub commented Dec 1, 2021

As far as I know there are only 6 scopes:

  • compile
  • provided
  • runtime
  • test
  • system
  • import

(https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#dependency-scope)

@dhruviyengar
Copy link
Author

As far as I know there are only 6 scopes:

  • compile
  • provided
  • runtime
  • test
  • system
  • import

(https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#dependency-scope)

it actually does exist, it's to let the shade plugin know that this is a jar that needs to be shaded in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants