Skip to content

[Fix] restoring dropped code in imgjust#220

Merged
Elfangor93 merged 1 commit intoJoomGalleryfriends:v4.1.0from
reilldesign:restoring-dropped-code-in-imgjust
Jun 16, 2025
Merged

[Fix] restoring dropped code in imgjust#220
Elfangor93 merged 1 commit intoJoomGalleryfriends:v4.1.0from
reilldesign:restoring-dropped-code-in-imgjust

Conversation

@reilldesign
Copy link
Copy Markdown

When creating the imgjust repository #168, two lines of code are dropped in the imgjust libary. The insertion of the class end is important for the correct display of the hover effect at the last image in a row. Otherwise the set margin is also used here.

@reilldesign reilldesign changed the title restoring dropped code in imgjust [Fix] restoring dropped code in imgjust May 31, 2025
@Elfangor93
Copy link
Copy Markdown
Member

How does this lines change behavior? I am asking such that we can test...

@Elfangor93 Elfangor93 added needs testing This issue or pull request needs further testing GUI testing Tests can be perfomed using the GUI labels Jun 8, 2025
@reilldesign
Copy link
Copy Markdown
Author

It is possible to define a gap in the justified layout. This is respected by the hover title background. For all the last images in a row, however, this does not exist and we need a css class to set the margin to 0.

Justified-gap

@MrMusic
Copy link
Copy Markdown
Member

MrMusic commented Jun 10, 2025

I have tested this item ✅ successfully.
Thank you very much!

@Elfangor93 Elfangor93 merged commit 91c7c69 into JoomGalleryfriends:v4.1.0 Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI testing Tests can be perfomed using the GUI needs testing This issue or pull request needs further testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants