Skip to content

implicitly nullable parameters are deprecated in php 8.4#175

Closed
brianteeman wants to merge 14 commits intoJoomGalleryfriends:v4.1.0from
brianteeman:deprecated
Closed

implicitly nullable parameters are deprecated in php 8.4#175
brianteeman wants to merge 14 commits intoJoomGalleryfriends:v4.1.0from
brianteeman:deprecated

Conversation

@brianteeman
Copy link

@Elfangor93 Elfangor93 changed the base branch from master to v4.1.0 April 14, 2025 09:02
@Elfangor93
Copy link
Member

Thank you very much @brianteeman for this contribution!
I was not aware of this change in PHP 8.4 👍

I changed the PR to point towards the v4.1.0 branch as this is not a bug fix and I would like to add this code change in the next minor release.
See https://github.com/JoomGalleryfriends/JoomGallery/blob/master/docs/Contribution_en.md#contributing-a-feature

@brianteeman
Copy link
Author

Your choice which version you merge it into

@brianteeman
Copy link
Author

Since your rebase there are unrelated changes files in this PR but they should magically disappear when you upmerge changes in 4.0 to bring 4.1 up to date

Also please note I only looked at the component. I am fairly certain the same problem will exist in the plugins

@Elfangor93 Elfangor93 added this to the v4.1.0 milestone Apr 22, 2025
@Elfangor93
Copy link
Member

This PR is now included in PR #201. @brianteeman Thank you very much for your contribution!

@Elfangor93 Elfangor93 closed this Apr 30, 2025
@brianteeman brianteeman deleted the deprecated branch April 30, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants