Bugfix #155 for justified layout – image size - counter proposal#163
Closed
Elfangor93 wants to merge 5 commits intoJoomGalleryfriends:masterfrom
Closed
Bugfix #155 for justified layout – image size - counter proposal#163Elfangor93 wants to merge 5 commits intoJoomGalleryfriends:masterfrom
Elfangor93 wants to merge 5 commits intoJoomGalleryfriends:masterfrom
Conversation
Member
This change would also have to be applied to the 'gallery view' tmpl, as the same problem occurs there. |
Member
Author
|
Its better to solve this issue inside the javascript file... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #155.
It is a counter proposal for PR #162 . I dont think it makes sense to just set a random high value for
maxRowImgs. Better to adjust this value based on the number of images actually shown.