Skip to content

Fix P1 Windows packaging (#69179) and Terminal Deadlock (#69212) - #1

Merged
JonthanaHanh merged 1 commit into
mainfrom
fix/p1-windows-and-terminal-deadlock
Jul 22, 2026
Merged

JonthanaHanh merged 1 commit into
mainfrom
fix/p1-windows-and-terminal-deadlock

Conversation

@JonthanaHanh

Copy link
Copy Markdown
Owner

This PR addresses two P1 issues identified in the repository audit:

  1. Windows Packaging Architecture Enforcement ([Bug]: This app can't run on your computer (此应用无法在你的电脑上运行) NousResearch/hermes-agent#69179):

    • Updates apps/desktop/scripts/stage-native-deps.mjs to explicitly verify that x64 binaries are staged when targeting win32-x64.
    • This prevents silent packaging of host architecture binaries during cross-compilation/packaging flows on Windows.
  2. Terminal Compound Background Command Deadlock (fix(gateway): suppress the duplicate clarify tool-progress bubble (#69175) NousResearch/hermes-agent#69212):

    • Updates tools/terminal_tool.py's _rewrite_compound_background function to wrap trailing backgrounded commands in braces: A && B & -> A && { B & }.
    • This ensures Bash doesn't fork the entire compound command into a subshell that waits for a long-running background process, which previously caused terminal tool timeouts and stalls.

Verified the regex and logic for both fixes. Proceeding to P2 remediations next.

@JonthanaHanh
JonthanaHanh merged commit 20765c0 into main Jul 22, 2026
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant