Fix P1 Windows packaging (#69179) and Terminal Deadlock (#69212) - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two P1 issues identified in the repository audit:
Windows Packaging Architecture Enforcement ([Bug]: This app can't run on your computer (此应用无法在你的电脑上运行) NousResearch/hermes-agent#69179):
apps/desktop/scripts/stage-native-deps.mjsto explicitly verify that x64 binaries are staged when targetingwin32-x64.Terminal Compound Background Command Deadlock (fix(gateway): suppress the duplicate clarify tool-progress bubble (#69175) NousResearch/hermes-agent#69212):
tools/terminal_tool.py's_rewrite_compound_backgroundfunction to wrap trailing backgrounded commands in braces:A && B &->A && { B & }.Verified the regex and logic for both fixes. Proceeding to P2 remediations next.