[cmake] Fix pre-definintion and dynamic library installation, add options for examples and tests#1088
Merged
JonathanSalwan merged 1 commit intoJonathanSalwan:dev-v1.0from Feb 16, 2022
Conversation
…ions for examples and tests
Contributor
Author
|
Wow, so quickly. |
Owner
|
Btw @JackBoosY, regarding microsoft/vcpkg#23111 (comment) what fix are you talking about? |
Contributor
Author
Ah that's only fits for vcpkg, we don't need to fix that here. |
Contributor
Author
|
And there is another build issue: #1089 |
fengjixuchui
added a commit
to fengjixuchui/Triton
that referenced
this pull request
Feb 16, 2022
Merge pull request JonathanSalwan#1088 from JackBoosY/dev/jack/fix-bu…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TRITON_BUILDING_DLLis not exists, it should beBUILDING_DLL. SeeTriton/src/libtriton/includes/triton/dllexport.hpp
Lines 12 to 17 in 96104b1
BUILDING_DLLshould only be used in build process, so it must bePRIVATE, notPUBLIC.examplesandtests.Related: microsoft/vcpkg#23111