Skip to content

[cmake] Fix pre-definintion and dynamic library installation, add options for examples and tests#1088

Merged
JonathanSalwan merged 1 commit intoJonathanSalwan:dev-v1.0from
JackBoosY:dev/jack/fix-build-predefin
Feb 16, 2022
Merged

[cmake] Fix pre-definintion and dynamic library installation, add options for examples and tests#1088
JonathanSalwan merged 1 commit intoJonathanSalwan:dev-v1.0from
JackBoosY:dev/jack/fix-build-predefin

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Feb 16, 2022

  1. TRITON_BUILDING_DLL is not exists, it should be BUILDING_DLL. See
    #ifdef BUILDING_DLL
    #ifdef __GNUC__
    #define TRITON_EXPORT __attribute__ ((dllexport))
    #else
    #define TRITON_EXPORT __declspec(dllexport) // Note: actually gcc seems to also supports this syntax.
    #endif
  2. BUILDING_DLL should only be used in build process, so it must be PRIVATE, not PUBLIC.
  3. The dynamic library is not installed.
  4. Add options for feature examples and tests.

Related: microsoft/vcpkg#23111

@JonathanSalwan JonathanSalwan self-assigned this Feb 16, 2022
@JonathanSalwan JonathanSalwan added this to the v1.0 milestone Feb 16, 2022
@JonathanSalwan JonathanSalwan changed the base branch from master to dev-v1.0 February 16, 2022 09:33
@JonathanSalwan JonathanSalwan merged commit ebd74c5 into JonathanSalwan:dev-v1.0 Feb 16, 2022
@JackBoosY JackBoosY deleted the dev/jack/fix-build-predefin branch February 16, 2022 09:36
@JackBoosY
Copy link
Contributor Author

Wow, so quickly.

@JonathanSalwan
Copy link
Owner

Btw @JackBoosY, regarding microsoft/vcpkg#23111 (comment) what fix are you talking about?

@JackBoosY
Copy link
Contributor Author

Btw @JackBoosY, regarding microsoft/vcpkg#23111 (comment) what fix are you talking about?

Ah that's only fits for vcpkg, we don't need to fix that here.

@JackBoosY
Copy link
Contributor Author

And there is another build issue: #1089

fengjixuchui added a commit to fengjixuchui/Triton that referenced this pull request Feb 16, 2022
Merge pull request JonathanSalwan#1088 from JackBoosY/dev/jack/fix-bu…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants