update installation doc #1683
Merged
update installation doc #1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarnixCroes
commented
Mar 8, 2024
| #### Notes on upgrading versions generally: | ||
|
|
||
| If you just want the latest version in a new directory, go to the [releases](https://github.com/AdamISZ/joinmarket-clientserver/releases) page. | ||
| Binary executables (of JoinmarketQt) are currently being built only for Windows, please verify the signature on the .exe file attached to the release. |
Contributor
Author
There was a problem hiding this comment.
latest JM release don't have these, so removed it
|
|
||
| (to build `libsodium` after): | ||
|
|
||
| git clone git@github.com:jedisct1/libsodium.git |
Contributor
Author
There was a problem hiding this comment.
this doesn't work
so changed it
Member
There was a problem hiding this comment.
Yes, HTTPS is safer option for read-only access, for git@github.com to work, some additional configuration is needed.
| git checkout 490022745164b56439688b0fc04f9bd43578e5c3 | ||
| make clean | ||
| ./autogen.sh | ||
| ./configure --prefix JM_ROOT --enable-module-recovery --disable-jni --enable-experimental --enable-module-ecdh --enable-benchmark=no |
Contributor
Author
There was a problem hiding this comment.
--disable-jni this is an unrecognized option
related #1657
MarnixCroes
commented
Mar 8, 2024
docs/INSTALL.md
Outdated
| git clone git@github.com:bitcoin-core/secp256k1 | ||
| git clone https://github.com/bitcoin-core/secp256k1.git | ||
| cd secp256k1 | ||
| git checkout 490022745164b56439688b0fc04f9bd43578e5c3 |
Contributor
Author
There was a problem hiding this comment.
also, is this ok?
it's a very old commit
Member
There was a problem hiding this comment.
No, should be changed to git checkout v0.4.1, to match install.sh.
kristapsk
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.