Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GreenKeeper lockfile updates strictly execute first in CI #275

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

elenadimitrova
Copy link
Contributor

@elenadimitrova elenadimitrova commented Jul 10, 2018

Continuing attempts to make GK update the package lockfile in its PRs. This time we're potentially fixing the issue of GK requirement that it is the first job to be run and exiting before successful lockfile upload with Only running on first push of a new branch , example in https://circleci.com/gh/JoinColony/colonyNetwork/2411

To ensure it is the first job to be run, we isolate the GreenKeeper updates using sequential job execution to ensure the job that runs greenkeeper-lockfile is always executed first.

Solution inspired by greenkeeperio/greenkeeper-lockfile#50

Resulting workflow build https://circleci.com/workflow-run/2cf9a44a-b22a-450c-a8a5-81114a67098a

Additionally we make some improvements to the circle config by using templates to isolate repeating steps and moving the node_modules cache to its own ~/.cache/yarn

@area
Copy link
Member

area commented Jul 10, 2018

Is there a way to stop the build from continuing if the lockfile was updated? The subsequent steps triggered by this build won't have an updated lockfile, I don't think, and so their results aren't of interest to us (but the builds triggered by GK pushing the lockfile update will be).

@elenadimitrova
Copy link
Contributor Author

We still need to run the unit tests suite sure to check if a dependency update has broken build?

@elenadimitrova elenadimitrova force-pushed the maintenance/greenkeeper-ci-config branch 9 times, most recently from ddee621 to bcf2fce Compare July 11, 2018 07:47
@elenadimitrova elenadimitrova force-pushed the maintenance/greenkeeper-ci-config branch from bcf2fce to 99849e1 Compare July 11, 2018 15:07
@elenadimitrova elenadimitrova merged commit cb59bc6 into develop Jul 11, 2018
@elenadimitrova elenadimitrova deleted the maintenance/greenkeeper-ci-config branch July 11, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants