Compile warnings

[lazovicff]

Changes include:

• Refactored Authority contract to avoid stack depth error
• Removed unused imports
• Fixed compile and solium warnings such as:
  • line length
  • formating of more than 5 function arguments
  • unused function arguments
  • etc.

There are solium warnings for experimental features, im not sure if its safe to remove these.
Solc warnings for external libraries will unfortunately stay: ethereum/solidity#2675

[elenadimitrova]

There are some additional solium issues

572:26    warning    Code contains empty block                                                                   no-empty-blocks
  572:26    warning    An empty block shouldn't have any whitespace or comments between the braces, i.e., '{}'.    whitespace
  600:30    warning    Code contains empty block                                                                   no-empty-blocks
  600:30    warning    An empty block shouldn't have any whitespace or comments between the braces, i.e., '{}'.    whitespace

And also some remaining eslint issues mainly to do with console.log statements, which we should probably find a more generic way to handle since we have a lot.

[elenadimitrova]

I understand we reach the line limit above but can we at least keep view returns (bytes32) on the same line?

[elenadimitrova]

Put internal view at the end of the function declaration line above. That's what we've followed everywhere else I think. The returns.. can be on its own line to stand out

[elenadimitrova]

Sorry, forgot to mention in review, to check if we can disable no-experimental in solium checks to avoid these warnings

[lazovicff]

I prefer suppressing these warnings by fixing them. In case where that is not possible i would leave them. But i guess we can supress them and be more cautious, no strong feelings

[elenadimitrova]

You are not sufficiently informed when you say this, no hard feelings :)
To understand whether we need experimental pragmas you need to understand what they do, so read the documentation first before you decide to "fix" them. I want you to come back and tell me what each of the two experimental pragmas does and whether and why we need it.

Then check duaraghav8/Ethlint#201 where we've agreed this is a bad warning anyway that will be fixed in upcoming solium

[lazovicff]

I agree that we should keep experimental pragmas, but my comment was about whether we should supress warnings (any warning, not just about experimental pragmas) by turning off the rule in config file.

You are right that i could do a research of what benefits of these experimental features give us. Looking from solidity releases i can see that ABIEncoderV2 allows us to use structs and arbitrary length arrays as functions arguments and return values. And v0.5.0 will disallow uninitialized storage pointers, old constructor sintax, var keywork etc.

[elenadimitrova]

Yes, I was not arguing that we disable the rule to simply silence the warning. I was saying we should silence the rule because
a) we need those experimental pragmas so we can't remove like solium is asking
b) that solium rule is just wrong and will be removed in the next release anyway