Revert "Use t.TempDir() instead of os.MkdirTemp() in tests"

This reverts commit 9c7b291.

gopages/internal/generate/generate_test.go

@@ -265,8 +265,12 @@ func JSONFunc() {
 				tc.trySkip(t)
 			}
 			// create a new package "thing" and generate docs for it
-			thing := t.TempDir()
+			thing, err := os.MkdirTemp("", "")
+			require.NoError(t, err)
 			require.NoError(t, os.Chdir(thing))
+			t.Cleanup(func() {
+				os.RemoveAll(thing)
+			})
 			thingFS := osfs.New("")
 			outputFS := memfs.New()
 			writeFile := func(path, contents string) {

gopages/main_test.go

@@ -27,6 +27,9 @@ func TestMain(t *testing.T) {
 func TestMainArgs(t *testing.T) {
 	t.Parallel()
 	cmd.SetupTestExiter(t)
+	tmp, err := os.MkdirTemp("", "")
+	require.NoError(t, err)
+	defer os.RemoveAll(tmp)
 
 	for _, tc := range []struct {
 		description string
@@ -61,7 +64,6 @@ func TestMainArgs(t *testing.T) {
 			runner := func(string, flags.Args) error {
 				return tc.runnerErr
 			}
-			tmp := t.TempDir()
 			getWD := func() (string, error) {
 				return tmp, tc.wdErr
 			}
@@ -109,7 +111,9 @@ func testRun(t *testing.T, tc testRunTestCase) {
 	}
 
 	// create dummy repo to enable cloning
-	ghPagesDir := t.TempDir()
+	ghPagesDir, err := os.MkdirTemp("", "")
+	require.NoError(t, err)
+	defer os.RemoveAll(ghPagesDir)
 	const defaultBranch = "refs/heads/main"
 	ghPagesRepo, err := git.PlainInitWithOptions(ghPagesDir, &git.PlainInitOptions{
 		InitOptions: git.InitOptions{
@@ -132,7 +136,9 @@ func testRun(t *testing.T, tc testRunTestCase) {
 		Branch: defaultBranch,
 	}))
 
-	modulePath := t.TempDir()
+	modulePath, err := os.MkdirTemp("", "")
+	require.NoError(t, err)
+	defer os.RemoveAll(modulePath)
 	wd, err := os.Getwd()
 	require.NoError(t, err)
 	require.NoError(t, os.Chdir(modulePath))