Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate TestFactory.task for Task Transition Errors #873

Conversation

Prikshit7766
Copy link
Contributor

@Prikshit7766 Prikshit7766 commented Nov 6, 2023

Description

When running a Question-Answering (QA) task followed by summarization, it's suspected that TestFactory.task in transform/__init__.py may be causing errors. We need to investigate and verify if this variable is the source of the issue and, if so, ensure it updates correctly during task transitions to prevent errors.

when we run summarization after Question-Answering.
so

harness.generate()

image


Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Usage

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@Prikshit7766 Prikshit7766 changed the title updated transform/__init__.py Investigate TestFactory.task for Task Transition Errors Nov 6, 2023
@Prikshit7766 Prikshit7766 added the 🐛 Bug Something isn't working label Nov 6, 2023
@Prikshit7766 Prikshit7766 linked an issue Nov 6, 2023 that may be closed by this pull request
@ArshaanNazir ArshaanNazir merged commit b1b3563 into release/1.8.0 Nov 9, 2023
3 checks passed
@Prikshit7766 Prikshit7766 self-assigned this Nov 9, 2023
@ArshaanNazir ArshaanNazir deleted the investigate-testfactorytask-for-task-transition-errors branch November 16, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate TestFactory.task for Task Transition Errors
3 participants