Fix condition of jobs with build needd

Signed-off-by: John Niang <[email protected]>
JohnNiang · Jan 10, 2024 · aadf593 · aadf593
1 parent 75c4077
commit aadf593
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/.github/workflows/halo.yaml b/.github/workflows/halo.yaml
@@ -66,7 +66,7 @@ jobs:
 
   github-release:
     runs-on: ubuntu-latest
-    if: github.event_name == 'release'
+    if: always() && needs.build.result == 'success' && github.event_name == 'release'
     needs: build
     steps:
       - uses: actions/checkout@v3
@@ -81,7 +81,7 @@ jobs:
         run: gh release upload ${{ github.event.release.tag_name }} application/build/libs/*
 
   docker-build-and-push:
-    if: github.event_name == 'push' || github.event_name == 'release'
+    if: always() && needs.build.result == 'success' && (github.event_name == 'push' || github.event_name == 'release')
     runs-on: ubuntu-latest
     needs: build
     steps:
@@ -102,7 +102,7 @@ jobs:
           platforms: linux/amd64,linux/arm64/v8,linux/ppc64le,linux/s390x
 
   e2e-test:
-    if: github.event_name == 'pull_request' || github.event_name == 'push'
+    if: always() && needs.build.result == 'success' && (github.event_name == 'pull_request' || github.event_name == 'push')
     runs-on: ubuntu-latest
     needs: build
     steps: