Skip to content

Commit

Permalink
fixup! Use pnpm as package manager for react-router.
Browse files Browse the repository at this point in the history
  • Loading branch information
JohT committed May 27, 2024
1 parent 5f60f4d commit 95b161f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/typescript-code-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ jobs:
key:
${{ runner.os }}-${{ hashFiles('**/*.sh') }}

- name: Setup pnpm for react-router
uses: pnpm/[email protected]
with:
version: 8.10.5
# - name: Setup pnpm for react-router
# uses: pnpm/[email protected]
# with:
# version: 8.10.5

- name: Download ${{ env.PROJECT_NAME }}-${{ env.REACT_ROUTER_VERSION }}
working-directory: temp
Expand Down
9 changes: 6 additions & 3 deletions scripts/downloader/downloadReactRouter.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@

# Requires downloadMavenArtifact.sh

# Fail on any error (errexit = exit on first error, errtrace = error inherited from sub-shell ,pipefail exist on errors within piped commands)
set -o errexit -o errtrace -o pipefail

# Get the analysis name from the middle part of the current file name (without prefix "download" and without extension)
SCRIPT_FILE_NAME="$(basename -- "${BASH_SOURCE[0]}")"
SCRIPT_FILE_NAME_WITHOUT_EXTENSION="${SCRIPT_FILE_NAME%%.*}"
Expand Down Expand Up @@ -40,9 +43,9 @@ mkdir -p ./runtime/logs
git clone https://github.com/remix-run/react-router.git source
(
cd source || exit
git checkout "react-router@${PROJECT_VERSION}"
pnpm install --frozen-lockfile
npx --yes @jqassistant/ts-lce >./../runtime/logs/jqassostant-typescript-scan.log 2>&1
git checkout "react-router@${PROJECT_VERSION}" || exit
pnpm install --frozen-lockfile || exit
npx --yes @jqassistant/ts-lce >./../runtime/logs/jqassostant-typescript-scan.log 2>&1 || exit
)
mkdir -p artifacts
mv -nv "source/.reports/jqa/ts-output.json" "artifacts/ts-react-router-${PROJECT_VERSION}.json"
Expand Down

0 comments on commit 95b161f

Please sign in to comment.