git-commit-checks: comment on PR with error(s) #6
Conversation
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 47342fa: wip
|
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 46626ff: wip
47342fa: wip
a04b4c8: git-commit-checks: comment on PR with error(s)
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 46626ff: wip
47342fa: wip
a04b4c8: git-commit-checks: comment on PR with error(s)
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: a12e36e: wip
118a419: wip
46626ff: wip
47342fa: wip
a04b4c8: git-commit-checks: comment on PR with error(s)
Additional errors could not be shown... Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 4344306: wip
[Additional errors could not be shown...] Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 0a56b0d: wip
4344306: wip
a12e36e: wip
118a419: wip
46626ff: wip
47342fa: wip
a04b4c8: git-commit-checks: comment on PR with error(s)
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 3090f24: wip
0a56b0d: wip
4344306: wip
a12e36e: wip
118a419: wip
Additional errors could not be shown... Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: c90c631: wip
3090f24: wip
Additional errors could not be shown... Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 5b0a78b: wip
c90c631: wip
Additional errors could not be shown... Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: d6adefc: wip
5b0a78b: wip
c90c631: wip
3090f24: wip
0a56b0d: wip
4344306: wip
a12e36e: wip
118a419: wip
46626ff: wip
47342fa: wip
a04b4c8: git-commit-checks: comment on PR with error(s)
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
Joe-Downs
force-pushed
the
pr/commit-checker-messages
branch
2 times, most recently
from
f2208e9 to
08d0430
Compare
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
Looks great! Let's PR this to the main OMPI repo.
This adds comments onto the pull request containing what caused the commit checks to fail, if any, and suggests fixes to the user. If no errors are raised, no comment is made. GitHub says there's a limit of 65536 characters on comments. If the bot's comment is over that limit, it will truncate the comment to fit, and add a message explaining where the remaining errors can be found. Unfortunately, the GitHub API doesn't seem to provide a job's unique ID for linking to a job run (this is different than an action run: ".../runs/..." vs ".../actions/runs/...", respectively), so we can't directly link to the error messages printed to the console. Additionally, to create this link, two new environment variables are used: GITHUB_RUN_ID and GITHUB_SERVER_URL. Because we need the PR object twice, check_github_pr_description() was also changed to have the PR object passed into it; the PR object is gotten with a new function, get_github_pr(). The GitHub action configuration was changed to run on pull_request_target, instead of pull_request. This allows the action to be run in the context of the base of the PR, rather than in the context of the merge commit. Therefore, the action is run even if the PR has merge conflicts. Signed-off-by: Joe Downs <[email protected]>
Joe-Downs
force-pushed
the
pr/commit-checker-messages
branch
from
08d0430 to
515e9aa
Compare
This adds comments onto the pull request containing what caused the commit
checks to fail, if any, and suggests fixes to the user. If no errors are raised,
no comment is made.
Because we need the PR object twice, check_github_pr_description() was also
changed to have the PR object passed into it; the PR object is gotten with a new
function, get_github_pr().