Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(json): add tests #52

Merged
merged 2 commits into from
Oct 14, 2022
Merged

feat(json): add tests #52

merged 2 commits into from
Oct 14, 2022

Conversation

georgettica
Copy link
Contributor

@georgettica georgettica commented Oct 14, 2022 •
edited
Loading

this will add tests to json files
closes #49

@georgettica georgettica changed the title init: json test feat(json): add tests Oct 14, 2022
@georgettica georgettica marked this pull request as ready for review October 14, 2022 14:55
@georgettica
Copy link
Contributor Author

as I reacall, json does not support comments, thus none were added

@JoaoDanielRufino JoaoDanielRufino added hacktoberfest Hacktoberfest event hacktoberfest-accepted Hacktoberfest accepted pull request labels Oct 14, 2022
JoaoDanielRufino
JoaoDanielRufino approved these changes Oct 14, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the amazing contribution!

@JoaoDanielRufino JoaoDanielRufino merged commit 84bf6e8 into JoaoDanielRufino:master Oct 14, 2022
@georgettica georgettica deleted the feature/georgettica/json-test branch October 14, 2022 15:05
@georgettica
Copy link
Contributor Author

after fumbling around a bit, I think I got it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoDanielRufino JoaoDanielRufino JoaoDanielRufino approved these changes

Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest event hacktoberfest-accepted Hacktoberfest accepted pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JSON code sample for tests
3 participants
@georgettica @JoaoDanielRufino @othorotka