Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C language code sample for tests #30

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Add C language code sample for tests #30

merged 1 commit into from
Oct 4, 2022

Conversation

miles170
Copy link
Contributor

@miles170 miles170 commented Oct 3, 2022

Closes #25.

@miles170 miles170 marked this pull request as draft October 3, 2022 02:13
@miles170 miles170 marked this pull request as ready for review October 3, 2022 02:34
@JoaoDanielRufino JoaoDanielRufino mentioned this pull request Oct 3, 2022
Closed
JoaoDanielRufino
JoaoDanielRufino requested changes Oct 3, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks for creating this PR.

test/fixtures/code_samples/go.mod Outdated Show resolved Hide resolved
@JoaoDanielRufino JoaoDanielRufino added the hacktoberfest Hacktoberfest event label Oct 3, 2022
JoaoDanielRufino
JoaoDanielRufino requested changes Oct 3, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file test/fixtures/code_samples/go.mod is still there, could you DELETE the file ?

@miles170
Copy link
Contributor Author

miles170 commented Oct 4, 2022 •
edited
Loading

If I delete test/fixtures/code_samples/go.mod, go list ./... will throw package github.com/JoaoDanielRufino/gcloc/test/fixtures/code_samples: C source files not allowed when not using cgo or SWIG: main.c

Or I should rename main.c to _main.c

JoaoDanielRufino
JoaoDanielRufino approved these changes Oct 4, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@JoaoDanielRufino JoaoDanielRufino merged commit e32353b into JoaoDanielRufino:master Oct 4, 2022
@miles170 miles170 deleted the c-code-sample branch October 4, 2022 13:13
@JoaoDanielRufino JoaoDanielRufino added the hacktoberfest-accepted Hacktoberfest accepted pull request label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoDanielRufino JoaoDanielRufino JoaoDanielRufino approved these changes

Assignees

@miles170 miles170

Labels
hacktoberfest Hacktoberfest event hacktoberfest-accepted Hacktoberfest accepted pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add C language code sample for tests
2 participants
@miles170 @JoaoDanielRufino