Improvement: Use Debian Stretch instead of Alpine Linux as base OS image #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a DNS bug in Alpine that prevents name resolution working unless the search domain is specified explicitly (which is almost never done). Also updated NextCloud from v12.0.6 to v12.0.7.
lower29
commented
May 22, 2018
| @@ -1 +1 @@ | |||
| sudo -u nextcloud php -d memory_limit=<MEMORY_LIMIT> -f /nextcloud/occ "$@" | |||
| sudo -E -u nextcloud php -d memory_limit=<MEMORY_LIMIT> -f /nextcloud/occ "$@" | |||
There was a problem hiding this comment.
This extra -E parameter is so that the environment gets passed to the command too, so that occ can access vars like DB_HOST etc so it can operate correctly.
lower29
commented
May 22, 2018
| @@ -53,7 +53,7 @@ cat > /nextcloud/config/autoconfig.php <<EOF; | |||
| 'dbport' => '${DB_PORT}', | |||
| 'dbtableprefix' => 'oc_', | |||
| EOF | |||
| if [[ ! -z "$ADMIN_USER" ]]; then | |||
| if [ ! -z "$ADMIN_USER" ]; then | |||
There was a problem hiding this comment.
Changing [[ to [ fixes the broken syntax for /bin/sh - only /bin/bash supports [[ (was previously masked by /bin/sh being alias for /bin/bash).
sevein
approved these changes
May 23, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes our NextCloud image to use Debian Stretch as its base OS rather than Alpine Linux.
The main reason for this change is that Alpine has a known bug in its DNS resolution that prevents non-qualified host names from being resolved properly. This prevents our NextCloud image from being able to resolve external database servers, amongst other things.
Our previous base image was actually a bundle of Alpine with Nginx and PHP installed, so the changes here include additional steps to install and configure these base components, which we now have to do ourselves.
This addresses RDSSARK-527.