Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: qualifies builtins types in TypeInfo::builtin #139

Merged
merged 6 commits into from
Jan 17, 2025
Merged

fix: qualifies builtins types in TypeInfo::builtin #139

merged 6 commits into from
Jan 17, 2025

Conversation

konn
Copy link
Collaborator

@konn konn commented Jan 17, 2025

Builtin type identifiers like int or string can be shadowed with local definitions. This PR avoids that by importing builtins module and qualifies identifier with it. There is still the case where builtins can accidentally redefined, but at least this change saves corner cases.

@konn konn requested a review from termoshtt January 17, 2025 07:01
@konn konn enabled auto-merge (squash) January 17, 2025 08:21
termoshtt
termoshtt approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@termoshtt termoshtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@konn konn merged commit 9660cd1 into main Jan 17, 2025
13 checks passed
@konn konn deleted the konn/qualify-builtin branch January 17, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@termoshtt termoshtt termoshtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konn @termoshtt