fix(server): isOverDataLimit logic to stop allowing 0 traffic byte #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue #1515 This if statement is just wrong and doesn't block access when traffic limit is set to 0 byte. This one character fixes it. Now if we create a new access key, set the limit to 0 before first usage, the client no longer will be able to connect.
fortuna
requested changes
Jun 5, 2024
sbruens
reviewed
Jun 12, 2024
|
I can't be a contributor. would you do it |
sbruens
changed the title
No problem. I added the requested changes to the PR. |
fortuna
approved these changes
Jul 15, 2024
|
Merged and we'll try and get this released soon. Thanks again for your contribution @cornzzy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #1515
This if statement is just wrong and doesn't block access when traffic limit is set to 0 byte. This one character fixes it.
Now if we create a new access key, set the limit to 0 before the first usage, the client no longer will be able to connect as expected.