fix(electron/linux): 💊 outline icon is not shown in Ubuntu Dock #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
changed the title
fortuna
approved these changes
May 20, 2022
jyyi1
added a commit
to Jigsaw-Code/outline-server
that referenced
this pull request
Jun 29, 2022
Our app's icon is not shown in Ubuntu Dock because of the wrong image path: <img width="870" alt="image" src="https://user-images.githubusercontent.com/93548144/176346973-d3285140-bbab-443d-97ad-04180c9094ac.png"> After the fix, the icon is shown correctly on all platforms: <img width="967" alt="image" src="https://user-images.githubusercontent.com/93548144/176346203-fe213ac6-d673-40b1-bdf9-52f385fb6649.png"> <img width="143" alt="image" src="https://user-images.githubusercontent.com/93548144/176458625-0a68f88a-4b72-4097-9b66-3357139e033c.png"> <img width="292" alt="image" src="https://user-images.githubusercontent.com/93548144/176459397-a6015e2a-50c0-4b90-9289-fe0c56d6d24b.png"> Related PR: Jigsaw-Code/outline-apps#1327
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our app's icon is not shown in Ubuntu Dock (on Windows it is fine):
Similar issues are reported to electron-builder (e.g., electron-userland/electron-builder#2269). Though the issue is declared to be "fixed", it is actually not, people are still using the workaround of setting main windows's icon in electron code.
In this fix, I use the workaround mentioned above which is to forcibly set the window icon to the 64x64 icon image. The following images illustrate the icon displayed under 100%, 150% and 200% dpi settings:
I did not set the icon to 128x128 because it actually looks too sharp under the regular DPI setting (100%), here a comparison between 64x64 and 128x128 under 100% dpi (though in higher dpi's, the 128x128 looks better):