-
Notifications
You must be signed in to change notification settings - Fork 1
Add TypeScript checking via JSDoc type annotations #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GrantASL19
wants to merge
26
commits into
main
Choose a base branch
from
feature/add-typescript-checking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
37c7cdc
Add TypeScript checking via JSDoc type annotations
GrantASL19 affda93
Remove "js/ts.implicitProjectConfig.checkJs" setting (unnecessary)
GrantASL19 f42f2fb
Exclude output directory from type checking
GrantASL19 b56eac0
Improve file organization and documentation:
GrantASL19 ec43d3b
Use inputConfig.appId as resolvedConfig.appId if provided (only infer…
GrantASL19 8f15d90
Merge branch 'main' into feature/add-typescript-checking
GrantASL19 61e63e4
Rename .scripts directories to scripts
GrantASL19 cc58ab9
In validateAndNormalizeConfig pass through entryUrl (used in capacito…
GrantASL19 75355ef
Build into provided output, falling back to `output/${new URL(inputCo…
GrantASL19 d88047e
Fix type error
GrantASL19 4894831
In tsconfig.json remove hidden directories from include (renamed .scr…
GrantASL19 f740949
Separate public (Config/ValidConfig) and internal config (InternalCon…
GrantASL19 808ca62
Rename InternalConfig["smartDialerConfig"] to InternalConfig["smartDi…
GrantASL19 56d65e5
Add VS Code configs to auto-format with final newlines and remove tra…
GrantASL19 9e1bdd0
Rename types and variables: Config → RawBuildConfig, ValidConfig → Va…
GrantASL19 e13a8fc
Refactor validateRawBuildConfig into isValidRawBuildConfig type guard
GrantASL19 a210e9b
Improve type descriptions
GrantASL19 42f83cd
Rename .vscode/settings.json to .vscode.suggestion/settings.json; add…
GrantASL19 a0ba7ce
Validate that rawBuildConfig.entryUrl is a valid URL; add fallback "a…
GrantASL19 32519eb
Add https://github.com/google/gts (tsconfig.json, .eslintrc.json, and…
GrantASL19 f15f821
In resolveBuildConfig replace nested ternary with if...else statements
GrantASL19 a2059f0
Inline DEFAULT_CONFIG into rawBuildConfig
GrantASL19 7fa63ea
Rename getYAMLBuildConfig → yamlBuildConfigToObject
GrantASL19 ec8e4f1
Moved all configuration logic into createConfig.mjs, which validate a…
GrantASL19 0265c46
Replace SmartDialerConfig type with object
GrantASL19 303a6e0
Add copyright headers
GrantASL19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| .DS_Store | ||
| output/ | ||
| node_modules/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "typescript.preferences.importModuleSpecifier": "relative", | ||
| "typescript.preferences.importModuleSpecifierEnding": "auto", | ||
| "typescript.preferences.quoteStyle": "single", | ||
| "typescript.tsdk": "node_modules/typescript/lib", | ||
| "typescript.enablePromptUseWorkspaceTsdk": true, | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
daniellacosse marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "compilerOptions": { | ||
| "allowJs": true, | ||
| "checkJs": true, | ||
| "noEmit": true, | ||
| "module": "node16", | ||
| "strict": true, | ||
| "esModuleInterop": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "skipLibCheck": true | ||
| }, | ||
| "include": [ | ||
| "**/*.cjs", | ||
| "**/*.mjs", | ||
| "**/*.js", | ||
| ], | ||
| "exclude": [ | ||
| "basic_navigator_example", // TODO: Remove this exclusion? | ||
| "node_modules", | ||
| "output" | ||
| ] | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.