-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add issue configuration and CI checks #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
reviewed
Jul 14, 2025
81650da to
e5f8d7e
Compare
fortuna
previously approved these changes
Jul 14, 2025
jyyi1
reviewed
Jul 16, 2025
Contributor
jyyi1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This will be useful!
fortuna
reviewed
Jul 16, 2025
wrapper_app_project/template/android/app/src/main/java/org/getoutline/pwa/Config.kt.handlebars
Show resolved
Hide resolved
wrapper_app_project/template/ios/App/App.xcodeproj/project.pbxproj.handlebars
Show resolved
Hide resolved
wrapper_app_project/template/android/app/src/main/res/values/strings.xml.handlebars
Show resolved
Hide resolved
Co-authored-by: Vinicius Fortuna <[email protected]>
jyyi1
approved these changes
Jul 23, 2025
Contributor
jyyi1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
fortuna
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements, including new GitHub issue templates, updated documentation, automated quality checks, and the addition of license headers to multiple files. These changes aim to streamline issue reporting, enhance build instructions, ensure code quality, and comply with licensing requirements.
GitHub Issue Templates and Configuration:
.github/ISSUE_TEMPLATE/bug_report.yml) to guide users in reporting issues, including steps to reproduce and environment details..github/ISSUE_TEMPLATE/feature_request.yml) to help users propose new features with detailed descriptions and use cases..github/ISSUE_TEMPLATE/config.yml).Documentation Updates:
README.mdto swap the iOS and Android build instructions, providing updated dependencies and clearer steps for building Android and iOS apps. [1] [2] [3]README.md, which was previously marked as a TODO.Automation and Quality Checks:
.github/workflows/quality_checks.yml) to automate quality checks, including Android and iOS builds and license header validation..vscode/settings.jsonfile to associate the YAML schema for GitHub issue configuration with the corresponding file.Licensing Compliance:
Note
Punting lint to a separate PR. GTS lints TS files with no way to properly configure it for MJS files: google/gts#655
We likely want to remove go and convert the existing files to TS before adding the Google-standard GTS linter.
Closes #5