Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes syntax error #2506 #2507

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fixes syntax error #2506 #2507

merged 2 commits into from
Sep 18, 2024

Conversation

tijko
Copy link
Contributor

@tijko tijko commented Sep 17, 2024

@tijko tijko requested a review from Jguer as a code owner September 17, 2024 18:18
radiooperator-19
radiooperator-19 suggested changes Sep 17, 2024
View reviewed changes
Copy link

@radiooperator-19 radiooperator-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not remove quotation marks; just use \" like other .po files

@tijko
Copy link
Contributor Author

tijko commented Sep 18, 2024 •
edited
Loading

Do not remove quotation marks; just use \" like other .po files

I actually did that in my original change but reverted when I noticed in en.po I see the overall format now.

I made the change though.

Jguer
Jguer approved these changes Sep 18, 2024
View reviewed changes
Copy link
Owner

@Jguer Jguer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems there's an issue with xgotext, I will check out what's happening there

@Jguer Jguer enabled auto-merge (squash) September 18, 2024 07:43
@Jguer Jguer merged commit 0f496c9 into Jguer:next Sep 18, 2024
1 check passed
@Jguer Jguer mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radiooperator-19 radiooperator-19 radiooperator-19 approved these changes

@Jguer Jguer Jguer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tijko @Jguer @radiooperator-19