-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tar support #1111
Remove tar support #1111
Conversation
I ended up removing |
Also reading through the ABS code, do we really need to shell out to |
d67c516
to
9ef6d51
Compare
A inheritance from the old inline tar.gz code, can be removed. |
#1102 now implements the changes to bash and zsh completion for this |
@@ -528,10 +526,6 @@ func handleConfig(option, value string) bool { | |||
config.AnswerUpgrade = value | |||
case "noanswerupgrade": | |||
config.AnswerUpgrade = "" | |||
case "gitclone": | |||
config.GitClone = true | |||
case "nogitclone": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also missing removal of case "tar" in both attribution and valid param
@@ -72,7 +72,6 @@ type Configuration struct { | |||
NoConfirm bool `json:"-"` | |||
Devel bool `json:"devel"` | |||
CleanAfter bool `json:"cleanAfter"` | |||
GitClone bool `json:"gitclone"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing removal of config.Tarbin
tar is slower and harder to diff. I doubt any one still uses it intentially. There's a chance some people have not cleared their cache in two years and still have tar based packages around. But forcing them to clear their cache is not a big deal at all.
Annoyingly when searching for |
Hi, sorry to be late, but for me, that feature was useful. I have to work behind an awkward proxy and --nogitclone was the only working solution to use AUR. With 9.4.3, I have no (easy) access to AUR. |
Oh boy... Any way you could add this back. Found this option useful for behind proxys. Much appreciated if we could get it back. |
tar is slower and harder to diff. I doubt any one still uses it intentially.
There's a chance some people have not cleared their cache in two years
and still have tar based packages around. But forcing them to clear
their cache is not a big deal at all.