Skip to content

Commit

Permalink
refactor: remove redundant len check (#2291)
Browse files Browse the repository at this point in the history
`len` returns 0 if the slice or map is nil. From the Go specification
[1]:

  "1. For a nil slice, the number of iterations is 0."
  "3. If the map is nil, the number of iterations is 0."

Therefore, an additional `len(v) != 0` check for before the loop is
unnecessary.

[1]: https://go.dev/ref/spec#For_range

Signed-off-by: Eng Zer Jun <[email protected]>
  • Loading branch information
Juneezee authored Sep 27, 2023
1 parent 299aa1e commit a112155
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
6 changes: 2 additions & 4 deletions get.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ func printPkgbuilds(dbExecutor download.DBSearcher, aurClient aur.QueryClient,
logger.Errorln(err)
}

if len(pkgbuilds) != 0 {
for target, pkgbuild := range pkgbuilds {
logger.Printf("\n\n# %s\n\n%s", target, string(pkgbuild))
}
for target, pkgbuild := range pkgbuilds {
logger.Printf("\n\n# %s\n\n%s", target, string(pkgbuild))
}

if len(pkgbuilds) != len(targets) {
Expand Down
6 changes: 2 additions & 4 deletions query.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,8 @@ func syncInfo(ctx context.Context, run *runtime.Runtime,
missing = true
}

if len(info) != 0 {
for i := range info {
printInfo(run.Logger, run.Cfg, &info[i], cmdArgs.ExistsDouble("i"))
}
for i := range info {
printInfo(run.Logger, run.Cfg, &info[i], cmdArgs.ExistsDouble("i"))
}

if missing {
Expand Down

0 comments on commit a112155

Please sign in to comment.