(#357) MappedProperty: should produce the current value on Advise #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iliya-usov
reviewed
Jul 5, 2023
| @@ -375,7 +374,7 @@ public MappedProperty(IViewableProperty<T> source, Func<T, R> map) | |||
| { | |||
| mySource = source; | |||
| myMap = map; | |||
| Change = new MappedSink<T, R>(source.Change, myMap); | |||
There was a problem hiding this comment.
This fix is not correct because Cange shouldn't provide an initial state, usually it is a signal.
I recommend rewriting the Advise method in the MappedProperty class as follows:
public void Advise(Lifetime lifetime, Action<R> handler) => mySource.Advise(lifetime, x => handler(myMap(x)));
There was a problem hiding this comment.
Yup, thanks, I'll take a look.
Iliya-usov
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #357.