Support time and random native calls in trace debugger #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhelenskiy
force-pushed
the
native-calls-attempt2
branch
2 times, most recently
from
5f3b23e to
f9ed737
Compare
eupp
requested changes
Feb 21, 2025
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/NativeCallsUtils.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/trace_debugger/RandomTests.kt
Show resolved
Hide resolved
...m/main/org/jetbrains/kotlinx/lincheck/transformation/transformers/DeterminismTransformers.kt
Outdated
Show resolved
Hide resolved
zhelenskiy
force-pushed
the
native-calls-attempt2
branch
2 times, most recently
from
0386148 to
7438d15
Compare
eupp
requested changes
Feb 27, 2025
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/MethodCallResultsTracker.kt
Outdated
Show resolved
Hide resolved
...vm/test/org/jetbrains/kotlinx/lincheck_test/representation/KotlinRandomRepresentationTest.kt
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/trace_debugger/RandomTests.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/trace_debugger/RandomTests.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/util/TestUtils.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/AbstractLincheckTest.kt
Show resolved
Hide resolved
…ts for deterministic randomness and fix found bugs
zhelenskiy
force-pushed
the
native-calls-attempt2
branch
2 times, most recently
from
9076cbe to
f442e36
Compare
…of the instrumentation side. Also, combine native calls handling with `beforeMethodCall`
zhelenskiy
force-pushed
the
native-calls-attempt2
branch
from
f442e36 to
98421d4
Compare
zhelenskiy
force-pushed
the
native-calls-attempt2
branch
from
405a114 to
f1c3a34
Compare
eupp
requested changes
Mar 3, 2025
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/MethodCallResultsTracker.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/util/native_calls/DeterministicMethodDescriptor.kt
Outdated
Show resolved
Hide resolved
...main/org/jetbrains/kotlinx/lincheck/util/native_calls/DeterministicRandomMethodDescriptor.kt
Show resolved
Hide resolved
...main/org/jetbrains/kotlinx/lincheck/util/native_calls/DeterministicRandomMethodDescriptor.kt
Outdated
Show resolved
Hide resolved
...m/main/org/jetbrains/kotlinx/lincheck/util/native_calls/PureDeterministicMethodDescriptor.kt
Outdated
Show resolved
Hide resolved
|
|
||
| internal fun getDeterministicMethodDescriptorOrNull(methodCallInfo: MethodCallInfo) = | ||
| getDeterministicTimeMethodDescriptorOrNull(methodCallInfo) | ||
| ?: getDeterministicRandomMethodDescriptorOrNull(methodCallInfo) |
There was a problem hiding this comment.
Let's use when here. It would also make it easier to extend this method for other trackers in the future.
There was a problem hiding this comment.
I don't understand you.
There was a problem hiding this comment.
when {
isTimeMehod(...) -> getDeterministicTimeMethodDescriptor(...)
isRandomMethod(...) -> getDeterministicRandomMethodDescriptor(...)
// we will add more cases here ...
else -> null
}There was a problem hiding this comment.
Do you want me to duplicate the checks inside the methods?
src/jvm/test-jdk11/org/jetbrains/kotlinx/lincheck_test/trace_debugger/SecureRandomTest.kt
Show resolved
Hide resolved
zhelenskiy
force-pushed
the
native-calls-attempt2
branch
from
4c3be80 to
b5fc67e
Compare
zhelenskiy
force-pushed
the
native-calls-attempt2
branch
from
b5fc67e to
4a564d5
Compare
zhelenskiy
force-pushed
the
native-calls-attempt2
branch
from
d1e0cf1 to
7855194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.