Static memory snapshot: add support for Unsafe, VarHandle, AFU, kotlinx.atomicfu #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrii-artuhov
changed the base branch from
develop
to
trace-debugger-static-memory
dmitrii-artuhov
commented
Nov 29, 2024
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
dmitrii-artuhov
force-pushed
the
trace-debugger-system-calls
branch
from
881a74a to
fb813ab
Compare
dmitrii-artuhov
changed the title
dmitrii-artuhov
changed the title
|
Please note that you don't need to have special support for atomicfu -- it compiles to either AFU or VarHandle |
…ity methods of Arrays and Collections classes
dmitrii-artuhov
force-pushed
the
trace-debugger-system-calls
branch
from
d95fd4d to
2fd1a05
Compare
ndkoval
reviewed
Dec 12, 2024
| @@ -25,6 +25,57 @@ import java.util.* | |||
| import kotlin.coroutines.* | |||
| import kotlin.coroutines.intrinsics.* | |||
|
|
|||
| fun shouldTransformClass(className: String): Boolean { | |||
There was a problem hiding this comment.
It seems the code was moved from somewhere, but I do not see it removed in the original location.
There was a problem hiding this comment.
Also, I would suggest keeping the transformation-related logic in the corresponding package.
ndkoval
reviewed
Dec 12, 2024
| @@ -37,11 +37,22 @@ internal object AtomicFieldUpdaterNames { | |||
| val offsetField = updater.javaClass.getDeclaredField("offset") | |||
| val offset = UNSAFE.getLong(updater, UNSAFE.objectFieldOffset(offsetField)) | |||
|
|
|||
| return findFieldNameByOffsetViaUnsafe(targetType, offset) | |||
| return findFieldNameByOffsetViaUnsafe(targetType, offset).let { fieldName -> | |||
| if (fieldName != null) AtomicFieldUpdaterDescriptor(targetType, fieldName) | |||
There was a problem hiding this comment.
Please always add { .. } when the else branch is present.
ndkoval
reviewed
Dec 12, 2024
|
|
||
| runInIgnoredSection { | ||
| // process method effect on the static memory snapshot | ||
| processMethodEffectOnStaticSnapshot(owner, params) |
There was a problem hiding this comment.
You mean the name of the method or what it does?
This method checks what kind of function was called (Unsafe API, VarHandle API, Java AFU) and updates static snapshot accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly resolves issue #389.
This PR is aimed to add support for lazy tracking fields, that are accessed via:
System.arraycopy- right now some tests fail for this functionality. I have an assumption that this could be caused by jit compilation, when the same test (same scenario basically) succeeds forNiterations and fails onN+1th. I am investigating into that. Support for this call will be done via separate PR.kotlinx.atomicfu