API for the general-purpose model checker #411
Conversation
|
@dmitrii-artuhov thanks for the PR. |
dmitrii-artuhov
changed the title
ndkoval
changed the title
| ), | ||
| emptyList(), | ||
| null | ||
| ) |
There was a problem hiding this comment.
Please use CustomScenarioDSL.kt instead.
|
|
||
| val result = strategy.runInvocation() | ||
| val failure = strategy.verify(result, verifier) | ||
|
|
There was a problem hiding this comment.
Why so many empty lines for just a few lines of code ?)
|
|
||
| object Lincheck { | ||
| @JvmStatic | ||
| fun <R> verifyWithModelChecker( |
There was a problem hiding this comment.
Please add a kdoc explaining the usage of this function. In particular, mention that this function looks for exceptions being thrown inside the user provided lambda block.
| } | ||
|
|
||
| return null | ||
| } |
There was a problem hiding this comment.
Please add tests for this function.
For start, add few tests in representation sub-module and check that the trace is correctly collected.
| withLincheckJavaAgent(testCfg.instrumentationMode) { | ||
| val strategy = testCfg.createStrategy(Wrapper::class.java, scenario, null, null) | ||
| val verifier = testCfg.createVerifier() | ||
|
|
There was a problem hiding this comment.
BTW, I think somewhere here you need to enforce the bytecode transformation of the block::class.java (i.e. the class of the passed lambda). Otherwise the events inside the lambda would not be tracked.
I think once you'll add the tests you will see the problem.
| private class ExecutionExceptionsVerifier(@Suppress("UNUSED_PARAMETER") sequentialSpecification: Class<*>) : Verifier { | ||
| override fun verifyResults(scenario: ExecutionScenario?, results: ExecutionResult?): Boolean { | ||
| if (results == null) return true | ||
| // User `check(...)`'s will fail and put their exceptions as an execution result, we must track that and disallow such outcomes. |
There was a problem hiding this comment.
Please move this explanation to the kdoc of ExecutionExceptionsVerifier.
No description provided.