Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In FieldSearchHelper skip protected or private fields that cannot be read by Unsafe #367

Merged
merged 4 commits into from
Sep 2, 2024
Merged

In FieldSearchHelper skip protected or private fields that cannot be read by Unsafe #367

merged 4 commits into from
Sep 2, 2024

Conversation

eupp
Copy link
Collaborator

@eupp eupp commented Aug 22, 2024

No description provided.

@eupp
Copy link
Collaborator Author

eupp commented Aug 22, 2024

Should fix #340

@eupp eupp requested review from avpotapov00 and ndkoval August 22, 2024 15:31
@ndkoval ndkoval removed the request for review from avpotapov00 August 28, 2024 14:59
@eupp eupp requested a review from ndkoval August 29, 2024 19:42
@ndkoval
Copy link
Collaborator

ndkoval commented Aug 30, 2024

@eupp could you please check the red builds?

@eupp
skip hidden fields via runCatching
9e9fa69 
Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
Copy link
Collaborator Author

eupp commented Aug 30, 2024

It turns out Class::isHidden() and Class::isRecord() were introduced only in Java 15.
So I rollbacked to the exception-catching solution.

@ndkoval
Copy link
Collaborator

ndkoval commented Aug 31, 2024

@eupp, please add a comment to the code explaining the logic.

@eupp
add a comment
fd9517c 
Signed-off-by: Evgeniy Moiseenko <[email protected]>
@eupp
Copy link
Collaborator Author

eupp commented Sep 2, 2024

@eupp, please add a comment to the code explaining the logic.

@ndkoval, done

@ndkoval ndkoval merged commit 4175292 into develop Sep 2, 2024
15 checks passed
@ndkoval ndkoval deleted the fix-field-search-helper branch September 2, 2024 13:43
@eupp eupp mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkoval ndkoval ndkoval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eupp @ndkoval