Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimization improvement: try to remove two operations and move operations to init and post parts #350

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

ndkoval
Copy link
Collaborator

@ndkoval ndkoval commented Aug 1, 2024

For example, for ConcurrentLinkedDequeTest, it would be better to see

| -------------------------------------- |
|     Thread 1     |      Thread 2       |
| -------------------------------------- |
| addLast(1): void |                     |
| -------------------------------------- |
| pollFirst(): 1   | addFirst(0): void   |
|                  | peekLast(): 1 [0,1] |
| -------------------------------------- |

instead of

| -------------------------------------- |
|     Thread 1     |      Thread 2       |
| -------------------------------------- |
| addLast(1): void | addFirst(0): void   |
| pollFirst(): 1   | peekLast(): 1 [0,1] |
| -------------------------------------- |

Notably, it is possible to allow the parallel part to be empty, but that would require many changes -- Lincheck currently relies on the parallel part to be non-empty.

@ndkoval ndkoval requested a review from eupp August 1, 2024 15:13
@ndkoval ndkoval force-pushed the minimize-scenarios-better branch from 88b0ceb to 85cb09d Compare August 1, 2024 15:43
@ndkoval ndkoval changed the title Move operations to init/post parts when minimizing Minimization improvement: try to remove two operations and move operations to init and post parts Aug 1, 2024
@ndkoval ndkoval merged commit d8cdbee into develop Aug 1, 2024
15 checks passed
@ndkoval ndkoval deleted the minimize-scenarios-better branch August 1, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants