AllowExtraSuspension parameter deprecated, SUSPENDED prefix removed from the output #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. SUSPENDED prefix removed from the output
ndkoval
requested changes
Jul 9, 2024
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/verifier/AllowExtraSuspensionTest.kt
Show resolved
Hide resolved
added 2 commits
July 9, 2024 23:28
ndkoval
requested changes
Jul 15, 2024
| } | ||
|
|
||
| private fun kotlin.Result<Any?>.toLinCheckResult(wasSuspended: Boolean) = | ||
| if (isSuccess) { | ||
| when (val value = getOrNull()) { | ||
| is Unit -> if (wasSuspended) SuspendedVoidResult else VoidResult | ||
| // Throwable was returned as a successful result | ||
| is Throwable -> ValueResult(value::class.java, wasSuspended) | ||
| else -> ValueResult(value, wasSuspended) | ||
| is Throwable -> ValueResult(value::class.java) |
There was a problem hiding this comment.
Shouldn't it be ExceptionResult?
There was a problem hiding this comment.
No, this is a case when Throwable was returned as a successful result, see comment above
There was a problem hiding this comment.
Why should you extract a class in one case and a value in another? ExceptionResult should be a successful one as well.
There was a problem hiding this comment.
I suppose the current code is (and was) buggy here.
There was a problem hiding this comment.
Ok, I agree, let's treat this case as a regular one, creating ValueResult(value) here.
ndkoval
requested changes
Jul 17, 2024
| } | ||
|
|
||
| private fun kotlin.Result<Any?>.toLinCheckResult(wasSuspended: Boolean) = | ||
| if (isSuccess) { | ||
| when (val value = getOrNull()) { | ||
| is Unit -> if (wasSuspended) SuspendedVoidResult else VoidResult | ||
| // Throwable was returned as a successful result | ||
| is Throwable -> ValueResult(value::class.java, wasSuspended) | ||
| else -> ValueResult(value, wasSuspended) | ||
| is Throwable -> ValueResult(value::class.java) |
There was a problem hiding this comment.
I suppose the current code is (and was) buggy here.
ndkoval
approved these changes
Jul 17, 2024
ndkoval
deleted the
319-always-allow-extra-suspensions-and-do-not-show-suspended-in-the-result-when-an-operation-completes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #319