Spin locks detection enchancements #331

avpotapov00 · 2024-06-10T00:19:24Z

Closes #218, #219, adds recursive spin locks support and overall spin locks detection enhancements.

…g fixes.

# Conflicts: # bootstrap/src/sun/nio/ch/lincheck/EventTracker.kt # src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt # src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/LincheckClassVisitor.kt # src/jvm/test/org/jetbrains/kotlinx/lincheck_test/AbstractLincheckTest.kt

bootstrap/src/sun/nio/ch/lincheck/EventTracker.kt

.../main/org/jetbrains/kotlinx/lincheck/strategy/managed/modelchecking/ModelCheckingStrategy.kt

src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/TracePoint.kt

src/jvm/main/org/jetbrains/kotlinx/lincheck/Utils.kt

src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt

src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/LoopDetector.kt

build.gradle.kts

src/jvm/test/org/jetbrains/kotlinx/lincheck_test/representation/ScalaBugTest.kt

src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt

src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/LoopDetector.kt

src/jvm/main/org/jetbrains/kotlinx/lincheck/Utils.kt

src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/CodeLocations.kt

src/jvm/test/org/jetbrains/kotlinx/lincheck_test/AbstractLincheckTest.kt

src/jvm/test/resources/expected_logs/obstruction_freedom_violation_with_no_detected_cycle.txt

.../main/org/jetbrains/kotlinx/lincheck/strategy/managed/modelchecking/ModelCheckingStrategy.kt

ndkoval · 2024-06-26T08:59:12Z

@avpotapov00, could you please check the documentation with Grammarly or Grazie?

ndkoval · 2024-06-26T09:02:04Z

src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/TraceReporter.kt

+ * Provides the prefix output for the [TraceNode].
+ * @see TraceNodePrefixFactory
+ */
+internal fun interface PrefixProvider {


Isn't it always the same string for each instance?

What do you mean?

It is not the same string, prefix reflects depth call and sometimes includes arrows parts of the spin cycle. See the implementation and usages.

When you create a new PrefixProvider, does it always generate the same prefix? Or how does it work? What does Provider mean?

Please take a look at the org.jetbrains.kotlinx.lincheck.strategy.managed.TraceNodePrefixFactory documentation: it is described there.

src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt

ndkoval · 2024-06-26T09:08:00Z

src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt

@@ -821,6 +828,7 @@ abstract class ManagedStrategy(
            null
        }
        newSwitchPoint(iThread, codeLocation, tracePoint)
+        loopDetector.beforeWriteArrayElement(array, index, value)


Should it be called before newSwitchPoint or after? Why?

In the current implementation it doesn't matter. But it looks more logical after the newSwitchPoint call as after we back to a thread we want to trace field read after the switch, not before (as it will actually happen).

ndkoval · 2024-06-26T09:08:14Z

src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt

@@ -797,6 +803,7 @@ abstract class ManagedStrategy(
            null
        }
        newSwitchPoint(iThread, codeLocation, tracePoint)
+        loopDetector.beforeWriteField(obj, value)


Should it be called before newSwitchPoint or after? Why?

In the current implementation it doesn't matter. But it looks more logical after the newSwitchPoint call as after we back to a thread we want to trace field read after the switch, not before (as it will actually happen).

src/jvm/test/org/jetbrains/kotlinx/lincheck_test/representation/RecursiveSpinLockTest.kt

ndkoval · 2024-06-27T13:27:07Z

General comment: would the current IDEA plugin work with this PR being merged?

# Conflicts: # bootstrap/src/sun/nio/ch/lincheck/EventTracker.kt # src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt # src/jvm/test/resources/expected_logs/spin_lock_events_cut_inner_loop.txt

ndkoval

@eupp, please review the recent changes and merge the PR when it's ready.

src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/CodeLocations.kt

src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/LoopDetector.kt

Recursive spin lock detection support, spin lock detection related bu…

c7200b5

…g fixes.

avpotapov00 requested a review from ndkoval June 10, 2024 00:19

avpotapov00 self-assigned this Jun 10, 2024

avpotapov00 changed the base branch from master to develop June 10, 2024 00:19

Aleksandr.Potapov added 4 commits June 10, 2024 10:19

Timout increased

5c33ca3

Merge fixes

aea245e

Timeout increased

4879c90

avpotapov00 requested a review from eupp June 10, 2024 13:39

eupp requested changes Jun 13, 2024

View reviewed changes

avpotapov00 requested a review from eupp June 16, 2024 20:07

Review fixes

a3ffd75

eupp requested changes Jun 20, 2024

View reviewed changes

Review fixes

067953c

avpotapov00 requested a review from eupp June 22, 2024 14:16

eupp approved these changes Jun 25, 2024

View reviewed changes

ndkoval reviewed Jun 25, 2024

View reviewed changes

.../main/org/jetbrains/kotlinx/lincheck/strategy/managed/modelchecking/ModelCheckingStrategy.kt Outdated Show resolved Hide resolved

ndkoval reviewed Jun 26, 2024

View reviewed changes

eupp reviewed Jun 26, 2024

View reviewed changes

src/jvm/test/org/jetbrains/kotlinx/lincheck_test/representation/RecursiveSpinLockTest.kt Outdated Show resolved Hide resolved

eupp reviewed Jun 26, 2024

View reviewed changes

src/jvm/test/org/jetbrains/kotlinx/lincheck_test/representation/RecursiveSpinLockTest.kt Outdated Show resolved Hide resolved

Aleksandr.Potapov and others added 2 commits July 2, 2024 18:35

Merge branch 'refs/heads/develop' into recusrive-spin-locks

f89586a

# Conflicts: # bootstrap/src/sun/nio/ch/lincheck/EventTracker.kt # src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt # src/jvm/test/resources/expected_logs/spin_lock_events_cut_inner_loop.txt

Review fixes

d8fb339

avpotapov00 requested a review from ndkoval July 3, 2024 15:15

Some KDoc added

4171913

ndkoval requested a review from eupp July 8, 2024 18:31

ndkoval approved these changes Jul 8, 2024

View reviewed changes

Minor fixes

f386866

ndkoval mentioned this pull request Jul 9, 2024

Spin locks detection enhancements #228

Closed

2 tasks

Aleksandr.Potapov added 3 commits July 9, 2024 22:16

Minor fix

89818b0

Minor fix

bd38ad3

Minor fix

190684d

eupp approved these changes Jul 10, 2024

View reviewed changes

ndkoval reviewed Jul 10, 2024

View reviewed changes

src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/CodeLocations.kt Outdated Show resolved Hide resolved

ndkoval reviewed Jul 10, 2024

View reviewed changes

src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/LoopDetector.kt Outdated Show resolved Hide resolved

Minor fix

3fc1d65

avpotapov00 merged commit 26f2bb6 into develop Jul 10, 2024
15 checks passed

avpotapov00 deleted the recusrive-spin-locks branch July 10, 2024 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spin locks detection enchancements #331

Spin locks detection enchancements #331

avpotapov00 commented Jun 10, 2024

ndkoval commented Jun 26, 2024 •

edited

Loading

ndkoval Jun 26, 2024

avpotapov00 Jul 2, 2024

avpotapov00 Jul 2, 2024

ndkoval Jul 3, 2024

avpotapov00 Jul 4, 2024

ndkoval Jun 26, 2024

avpotapov00 Jul 2, 2024

ndkoval Jun 26, 2024

avpotapov00 Jul 2, 2024

ndkoval commented Jun 27, 2024

ndkoval left a comment

Spin locks detection enchancements #331

Spin locks detection enchancements #331

Conversation

avpotapov00 commented Jun 10, 2024

ndkoval commented Jun 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ndkoval commented Jun 27, 2024

ndkoval left a comment

Choose a reason for hiding this comment

ndkoval commented Jun 26, 2024 •

edited

Loading