Execution results are presented in case of any failure #314
Conversation
src/jvm/test/resources/expected_logs/infinite_spin_loop_events_cut.txt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/LincheckFailure.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/runner/ParallelThreadsRunner.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/execution/ExecutionResult.kt
Outdated
Show resolved
Hide resolved
| @@ -27,20 +27,22 @@ class CompletedInvocationResult( | |||
| /** | |||
| * Indicates that the invocation has run into deadlock or livelock found by [ManagedStrategy]. | |||
| */ | |||
| data object ManagedDeadlockInvocationResult : InvocationResult() | |||
| class ManagedDeadlockInvocationResult(val results: ExecutionResult) : InvocationResult() | |||
There was a problem hiding this comment.
Now that all invocation results contain results field, let's propagate this field to the parent class InvocationResult.
There was a problem hiding this comment.
No, take a look at
data object SpinCycleFoundAndReplayRequired: InvocationResult():
it doesn't contain results
There was a problem hiding this comment.
So let's change it to also contain results?)
Then it would be uniform, no special cases, no needs to do type-casts and type-checks (i.e. result is CompletedInvocationResult) when we want to access results field, etc.
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/LincheckFailure.kt
Outdated
Show resolved
Hide resolved
| @@ -27,20 +27,22 @@ class CompletedInvocationResult( | |||
| /** | |||
| * Indicates that the invocation has run into deadlock or livelock found by [ManagedStrategy]. | |||
| */ | |||
| data object ManagedDeadlockInvocationResult : InvocationResult() | |||
| class ManagedDeadlockInvocationResult(val results: ExecutionResult) : InvocationResult() | |||
There was a problem hiding this comment.
So let's change it to also contain results?)
Then it would be uniform, no special cases, no needs to do type-casts and type-checks (i.e. result is CompletedInvocationResult) when we want to access results field, etc.
src/jvm/main/org/jetbrains/kotlinx/lincheck/runner/ParallelThreadsRunner.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/runner/ParallelThreadsRunner.kt
Outdated
Show resolved
Hide resolved
Closes #244