Byte-code transformation via a dynamically attached Java agent #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndkoval
force-pushed
the
javaagent-integration
branch
2 times, most recently
from
886880e to
8c633dc
Compare
ndkoval
force-pushed
the
javaagent-integration
branch
from
79ed0d3 to
09a2446
Compare
ndkoval
force-pushed
the
javaagent-integration
branch
from
09a2446 to
cdac29d
Compare
eupp
reviewed
Apr 5, 2024
src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/LincheckJavaAgent.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/LincheckJavaAgent.kt
Outdated
Show resolved
Hide resolved
eupp
approved these changes
Apr 8, 2024
…checkJavaAgent.kt Co-authored-by: Evgeniy Moiseenko <[email protected]> Signed-off-by: Nikita Koval <[email protected]>
…checkJavaAgent.kt Co-authored-by: Evgeniy Moiseenko <[email protected]> Signed-off-by: Nikita Koval <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
* ensure that the sequential specification class is always instrumented before starting verification Signed-off-by: Evgeniy Moiseenko <[email protected]>
* run intercepted continuation code inside ignored section Signed-off-by: Evgeniy Moiseenko <[email protected]>
* ensure verifier is called with LincheckJavaAgent installed Signed-off-by: Evgeniy Moiseenko <[email protected]>
* ensure verifier is called with LincheckJavaAgent installed Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
…kage Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
eupp
force-pushed
the
javaagent-integration
branch
from
133164d to
12ab98e
Compare
ndkoval
commented
Apr 18, 2024
| @@ -8,7 +8,7 @@ | |||
| * with this file, You can obtain one at http://mozilla.org/MPL/2.0/. | |||
| */ | |||
|
|
|||
| package org.jetbrains.kotlinx.lincheck | |||
| package org.jetbrains.kotlinx.lincheck.transformation | |||
There was a problem hiding this comment.
Please check that there is only one UnsafeHolder in the codebase and move it to the outer package -- it is now used not only for transformation.
| } | ||
| } | ||
|
|
||
| private fun readFieldViaUnsafe(obj: Any?, field: Field): Any? = |
There was a problem hiding this comment.
The same code is now used for the plugin, please keep only one version.
There was a problem hiding this comment.
Removed duplicate implementation, and put readFieldViaUnsafe into util package.
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.