Refactor byte-code transformation #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
ndkoval
reviewed
Mar 7, 2024
src/jvm/main/org/jetbrains/kotlinx/lincheck/runner/FixedActiveThreadsExecutor.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/runner/FixedActiveThreadsExecutor.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/transformation/LocalObjectsTests.kt
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/transformation/LocalObjectsTests.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/runner/ParallelThreadsRunnerExceptionTest.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/TracePoint.kt
Show resolved
Hide resolved
added 9 commits
March 14, 2024 22:01
# Conflicts: # src/jvm/main/org/jetbrains/kotlinx/lincheck/runner/FixedActiveThreadsExecutor.kt # src/jvm/main/org/jetbrains/kotlinx/lincheck/runner/ParallelThreadsRunner.kt # src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
eupp
reviewed
Mar 15, 2024
src/jvm/main/org/jetbrains/kotlinx/lincheck/TransformationClassLoader.java
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/bootstrap/CodeInformation.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/bootstrap/Injections.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/bootstrap/SharedEventsTracker.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/bootstrap/TestThread.kt
Outdated
Show resolved
Hide resolved
eupp
reviewed
Mar 15, 2024
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Show resolved
Hide resolved
eupp
approved these changes
Mar 15, 2024
ndkoval
requested changes
Mar 19, 2024
| @@ -46,5 +46,5 @@ internal interface EventTracker { | |||
| fun randomNextInt(): Int | |||
|
|
|||
| fun onNewObjectCreation(obj: Any) | |||
| fun addDependency(receiver: Any, value: Any?) | |||
| fun afterFieldAssign(receiver: Any, value: Any?) | |||
There was a problem hiding this comment.
You can do this in the code, you don't need byte-code instrumentation. Also, check function names in the LocalObjectManager class.
src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/LincheckClassVisitor.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/TransformationClassLoader.java
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/Strategy.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/TransformationClassLoader.java
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
ndkoval
requested changes
Mar 19, 2024
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/LincheckClassVisitor.kt
Outdated
Show resolved
Hide resolved
...brains/kotlinx/lincheck_test/representation/UnsafeUpdaterVarHandleTraceRepresentationTest.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/LincheckClassVisitor.kt
Show resolved
Hide resolved
ndkoval
approved these changes
Mar 19, 2024
ndkoval
changed the title
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor byte-code transformation for further replacing the custom class loaders with a dynamically attached javaagent. This is a part of #136.
Also, fixes #134 and several other issues discovered during the refactoring (see the added tests)