Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a race in FixedActiveThreadsExecutor #202

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Fix a race in FixedActiveThreadsExecutor #202

merged 2 commits into from
Jun 30, 2023

Conversation

avpotapov00
Copy link
Collaborator

@avpotapov00 avpotapov00 commented Jun 30, 2023 •
edited by ndkoval
Loading

There is a race in FixedActuveThreadsExecutor that may lead to a hang. This PR fixes the race and, hopefully, should also fix #194.

@avpotapov00 avpotapov00 requested a review from ndkoval June 30, 2023 13:21
@avpotapov00 avpotapov00 self-assigned this Jun 30, 2023
@ndkoval ndkoval changed the title FixedActiveThreadsExecutor fixed Fix a race in FixedActiveThreadsExecutor Jun 30, 2023
@ndkoval ndkoval merged commit 8578302 into develop Jun 30, 2023
@ndkoval ndkoval deleted the 201-fixedactivethreadexecutor-hung branch June 30, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkoval ndkoval ndkoval approved these changes

Assignees

@avpotapov00 avpotapov00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avpotapov00 @ndkoval