Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Params generator expanding range reset after scenario execution #180

Merged
merged 9 commits into from
May 12, 2023
Merged

Params generator expanding range reset after scenario execution #180

merged 9 commits into from
May 12, 2023

Conversation

avpotapov00
Copy link
Collaborator

No description provided.

@avpotapov00 avpotapov00 requested a review from ndkoval May 3, 2023 20:32
@avpotapov00 avpotapov00 self-assigned this May 3, 2023
ndkoval
ndkoval requested changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@ndkoval ndkoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! I've added some comments. By the way, why should ExpandingRangeIntGenerator be in Java, not in Kotlin?

src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ByteGen.java Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/LinChecker.kt Outdated Show resolved Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck/test/generator/ParamGeneratorsTests.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ParameterGenerator.java Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ExpandingRangeIntGenerator.java Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ExpandingRangeIntGenerator.java Outdated Show resolved Hide resolved
@avpotapov00 avpotapov00 requested a review from ndkoval May 4, 2023 11:12
@ndkoval ndkoval force-pushed the 179-reset-parameter-generators-between-scenario-generation branch from f17c917 to 99a5271 Compare May 4, 2023 13:53
ndkoval
ndkoval requested changes May 4, 2023
View reviewed changes
src/jvm/test/org/jetbrains/kotlinx/lincheck/test/generator/ParamGeneratorsTests.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ShortGen.java Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ParameterGenerator.java Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ExpandingRangeIntGenerator.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ExpandingRangeIntGenerator.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ExpandingRangeIntGenerator.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/LinChecker.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/CTestStructure.java Outdated Show resolved Hide resolved
@avpotapov00 avpotapov00 requested a review from ndkoval May 5, 2023 07:02
ndkoval
ndkoval requested changes May 8, 2023
View reviewed changes
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ParameterGenerators.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ParameterGenerators.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ParameterGenerators.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ParameterGenerators.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ParameterGenerators.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ParameterGenerators.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ExpandingRangeIntGenerator.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ExpandingRangeIntGenerator.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ParameterGenerators.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/LinChecker.kt Outdated Show resolved Hide resolved
@avpotapov00 avpotapov00 requested a review from ndkoval May 8, 2023 19:32
@ndkoval ndkoval added the bug Something isn't working label May 9, 2023
@ndkoval ndkoval force-pushed the 179-reset-parameter-generators-between-scenario-generation branch from 128344f to 861e2b5 Compare May 11, 2023 15:30
@ndkoval ndkoval merged commit 18e78a3 into develop May 12, 2023
@ndkoval ndkoval deleted the 179-reset-parameter-generators-between-scenario-generation branch May 12, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkoval ndkoval ndkoval approved these changes

Assignees

@avpotapov00 avpotapov00

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avpotapov00 @ndkoval