Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize internal synchronization #173

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

ndkoval
Copy link
Collaborator

@ndkoval ndkoval commented May 1, 2023

Surprisingly, this small change speeds up Lincheck twice.

@ndkoval ndkoval requested a review from avpotapov00 May 1, 2023 17:24
@ndkoval ndkoval force-pushed the optimize-synchronization branch from 7886b3c to 9b88d2f Compare May 3, 2023 10:18
@ndkoval
Copy link
Collaborator Author

ndkoval commented Jun 13, 2023

@avpotapov00, can you check whether the suggested change speeds up the tests on your machine?

@avpotapov00
Copy link
Collaborator

avpotapov00 commented Jun 13, 2023

@avpotapov00, can you check whether the suggested change speeds up the tests on your machine?

Yes, I already checked before I approved it, and this fix really speeds up Lincheck approximately twice (about 1.7 times on my machine)

@ndkoval
Copy link
Collaborator Author

ndkoval commented Jun 13, 2023

@avpotapov00 thank you!

@ndkoval ndkoval merged commit a2d8ca4 into develop Jun 13, 2023
@ndkoval ndkoval deleted the optimize-synchronization branch June 13, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants