Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed 'Class' instead of exception name in report #14

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Fixed 'Class' instead of exception name in report #14

merged 1 commit into from
Sep 5, 2019

Conversation

alefedor
Copy link
Contributor

Output in case of exceptions looked like

getOrException(1): Class

(i.e. exception name was lost)
Will be

getOrException(1): NoSuchElementException

@alefedor alefedor requested a review from ndkoval August 28, 2019 11:31
@alefedor @ndkoval
* Print exception name instead of Class in incorrect results message
f75022e 
* Store incorrect results messages into the corresponding `AssertionError` exceptions
ndkoval
ndkoval approved these changes Sep 5, 2019
View reviewed changes
Copy link
Collaborator

@ndkoval ndkoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Added a test
  2. The incorrect results message has been moved to the corresponding AssertionError.

@ndkoval ndkoval merged commit f91c372 into develop Sep 5, 2019
@ndkoval ndkoval deleted the exception-bug-fix branch September 5, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkoval ndkoval ndkoval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alefedor @ndkoval