Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug with wrong alignment in Reporter #10

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Fixed bug with wrong alignment in Reporter #10

merged 1 commit into from
Sep 5, 2019

Conversation

alefedor
Copy link
Contributor

@alefedor alefedor commented Aug 2, 2019

A fix for this: #9

@alefedor alefedor added the bug Something isn't working label Aug 2, 2019
@alefedor alefedor requested a review from ndkoval August 2, 2019 08:11
ndkoval
ndkoval requested changes Aug 29, 2019
View reviewed changes
Copy link
Collaborator

@ndkoval ndkoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a test with empty "init" and "post" scenario parts

ndkoval
ndkoval approved these changes Sep 5, 2019
View reviewed changes
Copy link
Collaborator

@ndkoval ndkoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the review comments

@ndkoval ndkoval merged commit 0de0f6b into develop Sep 5, 2019
@ndkoval ndkoval deleted the reporter-bug-fix branch September 5, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkoval ndkoval ndkoval approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alefedor @ndkoval