[JS IR] De-optimize equality operator as workaround for KT-57509

JetBrains · Apr 12, 2023 · 32d1fba · 32d1fba
1 parent 503ab6b
commit 32d1fba
Show file tree

Hide file tree

Showing 6 changed files with 44 additions and 2 deletions.
diff --git a/...c/org/jetbrains/kotlin/ir/backend/js/lower/calls/EqualityAndComparisonCallsTransformer.kt b/...c/org/jetbrains/kotlin/ir/backend/js/lower/calls/EqualityAndComparisonCallsTransformer.kt
@@ -84,8 +84,9 @@ class EqualityAndComparisonCallsTransformer(context: JsIrBackendContext) : Calls
         val equalsMethod = lhs.type.findEqualsMethod()
 
         return when {
-            lhs.type is IrDynamicType ->
-                irCall(call, intrinsics.jsEqeq)
+// Temporarily de-optimize dynamic equality due to KT-57509
+//            lhs.type is IrDynamicType ->
+//                irCall(call, intrinsics.jsEqeq)
 
             // Special optimization for "<expression> == null"
             lhs.isNullConst() || rhs.isNullConst() ->

diff --git a/js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/BoxJsTestGenerated.java b/js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/BoxJsTestGenerated.java
diff --git a/js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/fir/FirJsBoxTestGenerated.java b/js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/fir/FirJsBoxTestGenerated.java
diff --git a/js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/ir/IrBoxJsES6TestGenerated.java b/js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/ir/IrBoxJsES6TestGenerated.java
diff --git a/js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/ir/IrBoxJsTestGenerated.java b/js/js.tests/tests-gen/org/jetbrains/kotlin/js/test/ir/IrBoxJsTestGenerated.java
diff --git a/js/js.translator/testData/box/dynamic/lambdaParameterInlining.kt b/js/js.translator/testData/box/dynamic/lambdaParameterInlining.kt
@@ -0,0 +1,17 @@
+// WITH_STDLIB
+
+fun demo(x: dynamic, a: Array<out dynamic>): Boolean? {
+    return a.any { y: Any ->
+        val newX: Any = x.unsafeCast<Any>()
+        y == newX
+    }
+}
+
+data class X(val x: Int)
+
+fun box(): String {
+
+    if (demo(X(1), arrayOf(X(1))) != true) return "fail"
+
+    return "OK"
+}