Dependency graph resolves modules in the 2024.2 layout #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating dependency graph, resolve modules in the 2024.2.
Treat
IdeModuleas a plugin that treats itself as a module, in the same vein as if it was declared in the<module>element in the descriptor.This fixes reports of failed module/plugin resolutions in the dependency report, such as:
This resolves the situation in the
BundledPluginsRepositorywhich discovers plugin by the module ID (findPluginByModule). Since many bundled plugins now pose as platform modules, the bundled plugin that is both module and a plugin is now discovered with the same algorithm as the original bundled plugins which are not modules yet.See MP-6704 Plugin Verifier: Reports do not show properly resolved dependencies