OverrideOnly API declared within plugin and invoked from the plugin itself should not be reported #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It must take into account all ApiStatus variants. https://youtrack.jetbrains.com/issue/MP-6680 could we please have some tests for the others as well? |
YannCebron
reviewed
Jun 27, 2024
...er-core/src/main/java/com/jetbrains/pluginverifier/verifiers/filter/SameModuleUsageFilter.kt
Outdated
Show resolved
Hide resolved
Other annotations have a different mechanisms. I suggest focusing this PR on the |
YannCebron
reviewed
Jul 1, 2024
.../main/java/com/jetbrains/pluginverifier/verifiers/resolution/DisableSameModuleInvocations.kt
Outdated
Show resolved
Hide resolved
YannCebron
approved these changes
Jul 2, 2024
LChernigovskaya
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the plugin defines an API with
@ApiStatus.OverrideOnly, the invocations of such API elements from the plugin itself should not be reported as problems.ApiUsageFilterthat allows same-module invocations