Sync the TC recipes code with all the changes that have been made on …

…the TC side (#1182) * Update validation/parsing code to better match the corresponding code on TeamCity side Changes: add 'number' and 'password' inputs, rename 'ActionInputDescriptor#isRequired' to 'required', add 'InvalidNumberProblem', validate the length of `ActionStepWith`, make a couple of other changes to the validation logic * Forbid uploading zip archives * Rename actions to recipes * Fix typo 'body' -> 'a body'
JetBrains · Nov 4, 2024 · 8e5e042 · 8e5e042
1 parent 6ccfe5b
commit 8e5e042
Show file tree

Hide file tree

Showing 25 changed files with 1,519 additions and 1,393 deletions.
diff --git a/intellij-plugin-structure/README.md b/intellij-plugin-structure/README.md
@@ -8,16 +8,16 @@ even errors like `Directory 'lib' must not be empty` according to verification [
 
 There are different types of plugins: 
 
-| Plugin Type      | Module                       | Manager -> .createPlugin(Path pluginFile)     | API                     | 
-|------------------|------------------------------|-----------------------------------------------|-------------------------|  
-| IntelliJ         | `structure-intellij`         | `IdePluginManager.createManager()`            | `IdePlugin`             |
-| ReSharper        | `structure-dotnet`           | `ReSharperPluginManager.createManager()`      | `ReSharperPlugin`       |
-| EDU              | `structure-edu`              | `EduPluginManager.createManager()`            | `EduPlugin`             |
-| Fleet            | `structure-fleet`            | `FleetPluginManager.createManager()`          | `FleetPlugin`           |
-| Hub              | `structure-hub`              | `HubPluginManager.createManager()`            | `HubPlugin`             |
-| TeamCity         | `structure-teamcity`         | `TeamcityPluginManager.createManager()`       | `TeamcityPlugin`        |
-| TeamCity Actions | `structure-teamcity-actions` | `TeamCityActionPluginManager.createManager()` | `TeamCityActionPlugin`  |
-| YouTrack         | `structure-youtrack`         | `YouTrackPluginManager.createManager()`       | `YouTrackPlugin`        |
+| Plugin Type      | Module                       | Manager -> .createPlugin(Path pluginFile)     | API                    | 
+|------------------|------------------------------|-----------------------------------------------|------------------------|  
+| IntelliJ         | `structure-intellij`         | `IdePluginManager.createManager()`            | `IdePlugin`            |
+| ReSharper        | `structure-dotnet`           | `ReSharperPluginManager.createManager()`      | `ReSharperPlugin`      |
+| EDU              | `structure-edu`              | `EduPluginManager.createManager()`            | `EduPlugin`            |
+| Fleet            | `structure-fleet`            | `FleetPluginManager.createManager()`          | `FleetPlugin`          |
+| Hub              | `structure-hub`              | `HubPluginManager.createManager()`            | `HubPlugin`            |
+| TeamCity         | `structure-teamcity`         | `TeamcityPluginManager.createManager()`       | `TeamcityPlugin`       |
+| TeamCity Recipes | `structure-teamcity-recipes` | `TeamCityRecipePluginManager.createManager()` | `TeamCityRecipePlugin` |
+| YouTrack         | `structure-youtrack`         | `YouTrackPluginManager.createManager()`       | `YouTrackPlugin`       |
 
 *IntelliJ Plugins* may be in several forms:
 - single `.jar` file containing `/META-INF/plugin.xml`

diff --git a/intellij-plugin-structure/build.gradle.kts b/intellij-plugin-structure/build.gradle.kts
@@ -181,7 +181,7 @@ publishing {
     configurePublication("EduPublication", "structure-edu", "JetBrains Plugins Structure Edu", "Library for parsing JetBrains Edu plugins. Can be used to verify that plugin complies with JetBrains Marketplace requirements.")
     configurePublication("FleetPublication", "structure-fleet", "JetBrains Plugins Structure Fleet", "Library for parsing JetBrains Fleet plugins. Can be used to verify that plugin complies with JetBrains Marketplace requirements.")
     configurePublication("ToolboxPublication", "structure-toolbox", "JetBrains Plugins Structure Toolbox", "Library for parsing JetBrains Toolbox plugins. Can be used to verify that plugin complies with JetBrains Marketplace requirements.")
-    configurePublication("TeamCityActionsPublications", "structure-teamcity-actions", "JetBrains Plugins Structure TeamCity Actions", "Library for parsing JetBrains TeamCity actions. Can be used to verify that plugin complies with JetBrains Marketplace requirements.")
+    configurePublication("TeamCityRecipesPublications", "structure-teamcity-recipes", "JetBrains Plugins Structure TeamCity Recipes", "Library for parsing JetBrains TeamCity recipes. Can be used to verify that plugin complies with JetBrains Marketplace requirements.")
     configurePublication("YoutrackPublication", "structure-youtrack", "JetBrains Plugins Structure YouTrack Apps", "Library for parsing JetBrains YouTrack Apps. Can be used to verify that plugin complies with JetBrains Marketplace requirements.")
   }
 }
@@ -206,7 +206,7 @@ signing {
     sign(publishing.publications["EduPublication"])
     sign(publishing.publications["FleetPublication"])
     sign(publishing.publications["ToolboxPublication"])
-    sign(publishing.publications["TeamCityActionsPublications"])
+    sign(publishing.publications["TeamCityRecipesPublications"])
     sign(publishing.publications["YoutrackPublication"])
   }
 }

diff --git a/intellij-plugin-structure/settings.gradle.kts b/intellij-plugin-structure/settings.gradle.kts
@@ -12,7 +12,7 @@ include("structure-toolbox")
 include("structure-ide")
 include("structure-ide-classes")
 include("structure-youtrack")
-include("structure-teamcity-actions")
+include("structure-teamcity-recipes")
 include("tests")
 
 dependencyResolutionManagement {

diff --git a/...ure/structure-base/src/main/kotlin/com/jetbrains/plugin/structure/base/plugin/Settings.kt b/...ure/structure-base/src/main/kotlin/com/jetbrains/plugin/structure/base/plugin/Settings.kt
@@ -5,7 +5,6 @@
 package com.jetbrains.plugin.structure.base.plugin
 
 import org.apache.commons.io.FileUtils
-import java.io.File
 import java.nio.file.Path
 import java.nio.file.Paths
 
@@ -15,7 +14,7 @@ enum class Settings(private val key: String, private val defaultValue: () -> Str
   FLEET_PLUGIN_SIZE_LIMIT("intellij.structure.fleet.plugin.size.limit", { FileUtils.ONE_GB.toString() }),
   TOOLBOX_PLUGIN_SIZE_LIMIT("intellij.structure.toolbox.plugin.size.limit", { FileUtils.ONE_GB.toString() }),
   TEAM_CITY_PLUGIN_SIZE_LIMIT("intellij.structure.team.city.plugin.size.limit", { FileUtils.ONE_GB.toString() }),
-  TEAM_CITY_ACTION_SIZE_LIMIT("intellij.structure.team.city.action.size.limit", { FileUtils.ONE_MB.toString() }),
+  TEAM_CITY_RECIPE_SIZE_LIMIT("intellij.structure.teamcity.recipe.size.limit", { FileUtils.ONE_MB.toString() }),
   RE_SHARPER_PLUGIN_SIZE_LIMIT("intellij.structure.re.sharper.plugin.size.limit", { FileUtils.ONE_GB.toString() }),
   HUB_PLUGIN_SIZE_LIMIT("intellij.structure.hub.plugin.size.limit", { (FileUtils.ONE_MB * 30).toString() }),
   HUB_PLUGIN_MAX_FILES_NUMBER("intellij.structure.hub.plugin.max.files.number", { 1000.toString() }),

diff --git a/...rc/main/kotlin/com/jetbrains/plugin/structure/teamcity/action/TeamCityActionDescriptor.kt b/...rc/main/kotlin/com/jetbrains/plugin/structure/teamcity/action/TeamCityActionDescriptor.kt
diff --git a/...ions/src/main/kotlin/com/jetbrains/plugin/structure/teamcity/action/TeamCityActionSpec.kt b/...ions/src/main/kotlin/com/jetbrains/plugin/structure/teamcity/action/TeamCityActionSpec.kt